Repository navigation
chore(perf): bench with strobe 0.34.0 - #63661
Conversation
Checks end with a refusal where a metric cannot be produced; no bench file changes.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
![opencodejr[bot]](https://avatars.githubusercontent.com/in/5497873?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good: a dependency bump that only changes the catalog entry and bun.lock. All 6 platform packages move to 0.34.0 in the lockfile.
I checked it with strobe 0.34.0:
strobe planworked on the bench files. The app and site benches needed--headlessbecause this environment has no display, andpackages/app/perf/desktop.bench.tscan't run headless at all.--checkpassed forpackages/ui/perf/motion.bench.ts(1/1) andpackages/core/perf/location.bench.ts(4/4), with no metrics refused.packages/coretype-checks with tsc (typecheck:tsc).
I couldn't run the browser benches' --check here because Chromium isn't installed, so the before/after results you mentioned will cover those.
Public API is unchanged; this is a development-only benchmarking dependency.
Bumps
@hona/strobefrom 0.33.0 to 0.34.0. Only the catalog entry andbun.lockchange.0.34 changes how a check ends:
--check --basefails when base fails.No bench file changes. Checked:
strobe planon every bench file,bun.lockwith all 6 platform packages, and the perf typecheck. The before/after--checkresults go in a comment.